CASSANDRA-21491: Prevent ClientMetrics NPE during internode reactivation#4923
Open
edwardconnect wants to merge 1 commit into
Open
CASSANDRA-21491: Prevent ClientMetrics NPE during internode reactivation#4923edwardconnect wants to merge 1 commit into
edwardconnect wants to merge 1 commit into
Conversation
Keep client-specific paused connection accounting in CQLMessageHandler so internode backpressure does not access ClientMetrics before native transport initialization. Assisted-by: Codex:GPT-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: CASSANDRA-21491
Problem
AbstractMessageHandleris shared by native-transport and internode connections, but its reserve-capacity reactivation path unconditionally updatesClientMetrics. Internode messaging starts before native transport initializes those metrics, so reactivating a throttled internode connection can throw aNullPointerExceptionand terminate the connection.Solution
Move paused-client metric accounting behind a no-op connection-reactivation hook in
AbstractMessageHandler, and override the hook inCQLMessageHandler. This keeps the existing native-transport metric behavior while ensuring internode backpressure does not access client-only metrics.Add a regression test that exercises internode reserve-capacity reactivation before
ClientMetricsinitialization. The test fails with the reportedNullPointerExceptionbefore the fix.Tests
.build/sh/ai-ci-test org.apache.cassandra.net.AbstractMessageHandlerTest.build/sh/ai-ci-test org.apache.cassandra.transport.RateLimitingTest.build/sh/ai-build