Skip to content

Allow parallel execution of NAS backup and delete commands #12847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmsperu wants to merge 1 commit into
base: 4.20
Choose a base branch
from
+2 −2
Open

Allow parallel execution of NAS backup and delete commands #12847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/cloudstack/backup/DeleteBackupCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,6 @@ public void setMountOptions(String mountOptions) {

@Override
public boolean executeInSequence() {
return true;
return false;
Copy link
Contributor

@abh1sar abh1sar Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid concern. I think TakeBackup command can still be parallelized but not DeleteBackup. @jmsperu

}
}
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/cloudstack/backup/TakeBackupCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,6 @@ public void setVolumePaths(List<String> volumePaths) {

@Override
public boolean executeInSequence() {
return true;
return false;
}
}
Loading