Use array element type not basic type for primitive array access#520
Merged
garydgregory merged 1 commit intoJul 12, 2026
Merged
Conversation
getBasicType() drops the dimension count, so iaload on int[][] passed structural verification even though its component type is a reference; the ten primitive *aload/*astore constraints in InstConstraintVisitor now use getElementType() like the reference and byte/char siblings.
garydgregory
added a commit
that referenced
this pull request
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstConstraintVisitorchecks the primitive array load/store instructions withArrayType.getBasicType(), which returns the innermost basic type and drops the dimension count, soiaload/iastore(and thelong/float/double/shortvariants) applied directly to a multidimensional primitive array such asint[][]pass Pass3b even though the component type isint[], a reference. The reference/byte/char siblings (aaload/aastore,baload/bastore,castore) already usegetElementType(); this switches the ten primitive*aload/*astorechecks to match. For a one-dimensional arraygetElementType()returns the same object asgetBasicType(), so valid code verifies exactly as before. Found while auditing the*ALOAD/*ASTOREelement-type checks againstArrayType.mvn; that'smvnon the command line by itself.