fix indexOfDifference splitting a surrogate pair#1713
Open
alhudz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:getCommonPrefix("𐐀", "𐐁")returns the lone high surrogate\uD801, anddifference("𐐀", "𐐁")returns the lone low surrogate\uDC01. Both are malformed UTF-16.Cause:bothindexOfDifferenceoverloads walk the inputs onecharat a time, so when two strings share the high surrogate of a supplementary code point but differ in the low half, the reported index lands inside the pair (index1rather than0).getCommonPrefixthen slices the pair in half anddifferencestarts its result on the orphaned low half.Fix:when the difference falls on a low surrogate whose preceding (common)charis a high surrogate, report the start of the pair.getCommonPrefixanddifferencefollow for free. BMP inputs never hit the new branch, so existing behaviour is unchanged.mvn; that'smvnon the command line by itself.