[TEXT-179] Fix escaped nested variable pattern handling#751
Closed
LeandroAntunes39 wants to merge 1 commit into
Closed
[TEXT-179] Fix escaped nested variable pattern handling#751LeandroAntunes39 wants to merge 1 commit into
LeandroAntunes39 wants to merge 1 commit into
Conversation
LeandroAntunes39
changed the title
garydgregory
changed the title
Member
|
Jira ticket is https://issues.apache.org/jira/browse/TEXT-179 |
Member
|
@LeandroAntunes39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TEXT-179.
This change fixes the handling of escaped variable expressions that start with a nested variable prefix but do not contain a matching outer suffix.
Before this change,
$${${a}was processed in a way that allowed the inner${a}expression to be resolved after the escape character was removed, producing${1.The expected behavior is to keep the expression as
${${a}, because the escaped outer expression should be treated as a whole and the inner prefix should not be processed independently in this incomplete boundary pattern.The change preserves the existing behavior for complete escaped nested expressions such as
$${${a}}, which still resolves to${1}, and for standard escaped expressions such as$${animal}, which still resolves to${animal}.Added/enabled regression coverage in
StringSubstitutorTest.