feat: Support Spark expression str_to_map#3654
Open
unknowntpo wants to merge 2 commits intoapache:mainfrom
Open
feat: Support Spark expression str_to_map#3654unknowntpo wants to merge 2 commits intoapache:mainfrom
str_to_map#3654unknowntpo wants to merge 2 commits intoapache:mainfrom
Conversation
unknowntpo
changed the title
unknowntpo
changed the title
str_to_map
unknowntpo
force-pushed
the
feat-str-to-map-on-main
branch
from
d56a2f2 to
39e444b
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
unknowntpo
force-pushed
the
feat-str-to-map-on-main
branch
from
39e444b to
70f7686
Compare
comphead
reviewed
Apr 22, 2026
| SELECT str_to_map(col) FROM (VALUES ('a:1,b:2'), ('x:9'), (NULL)) AS t(col) | ||
|
|
||
| -- Multi-row with custom delimiter | ||
| query spark_answer_only |
Contributor
There was a problem hiding this comment.
to check Comet enabled we need to remove spark_answer_only for all possible queries
comphead
reviewed
Apr 22, 2026
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @unknowntpo for your contribution, I think to prove it works we need to run test queries with just query to let them run with Comet and also it would be nice to support all datatypes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3168
Rationale for this change
Comet does not yet support Spark
StringToMap, so this change wires it through serde and native execution.What changes are included in this PR?
StringToMapto the nativeSparkStrToMapUDFSparkStrToMapin the native function registrystr_to_mapHow are these changes tested?