chore: Refactor planner random and partition expressions#3704
Merged
andygrove merged 3 commits intoapache:mainfrom Mar 17, 2026
Merged
chore: Refactor planner random and partition expressions#3704andygrove merged 3 commits intoapache:mainfrom
andygrove merged 3 commits intoapache:mainfrom
Conversation
coderfender
changed the title
coderfender
changed the title
Contributor
Author
|
Tagging @mbutrovich for review |
coderfender
commented
Mar 16, 2026
| /// Return partition id of this planner. | ||
| pub fn partition(&self) -> i32 { | ||
| self.partition | ||
| } |
Contributor
Author
There was a problem hiding this comment.
had to add a method since partition field is private which was not being accessed outside this file before refactor (SparkPartitionId , MonotonicallyIncreasingId functions leverage this)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3705
Rationale for this change
What changes are included in this PR?
How are these changes tested?