Fix the tokenization of < edge cases#2280
Merged
iffyio merged 2 commits intoapache:mainfrom Mar 26, 2026
Merged
Conversation
iffyio
reviewed
Mar 20, 2026
iffyio
approved these changes
Mar 26, 2026
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @ayman-sigma!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes tokenizer behavior for
<prefixed sequences so subtraction and comparison are parsed correctly instead of being treated as an operator start. The issue mainly happens when there is no space between<and other tokens like-, or=.This PR address:
+or-after<(Lt) to identify the sign of the following number/identifier+or-after<=(LtEq)<->the same for dialects that supports geometric types.