[physical-plan]: remove deprecated spill_record_batch_by_size

[alamb]

Which issue does this PR close?

• N/A.

Rationale for this change

datafusion_physical_plan::spill::spill_record_batch_by_size was deprecated in DataFusion 46.0.0 in favor of SpillManager::spill_record_batch_by_size.

The API health policy deprecation guidelines say deprecated methods remain for 6 major versions or 6 months, whichever is longer. This API has exceeded that window, so this removes the deprecated wrapper.

What changes are included in this PR?

• Removes the deprecated datafusion_physical_plan::spill::spill_record_batch_by_size function.

Are these changes tested?

By CI

Are there any user-facing changes?

Yes. This removes a public Rust API that was deprecated in DataFusion 46.0.0. Downstream users should migrate to datafusion_physical_plan::spill::SpillManager::spill_record_batch_by_size.

This is an API change and should be labeled api-change.

[github-actions]

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details

     Cloning apache/main
    Building datafusion-physical-plan v54.0.0 (current)
       Built [  35.948s] (current)
     Parsing datafusion-physical-plan v54.0.0 (current)
      Parsed [   0.138s] (current)
    Building datafusion-physical-plan v54.0.0 (baseline)
       Built [  35.164s] (baseline)
     Parsing datafusion-physical-plan v54.0.0 (baseline)
      Parsed [   0.139s] (baseline)
    Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.878s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_missing.ron

Failed in:
  function datafusion_physical_plan::spill::spill_record_batch_by_size, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/4bfa2adb465669693e476adfe85560e4239d04b5/datafusion/physical-plan/src/spill/mod.rs:255

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  74.232s] datafusion-physical-plan