fix: union coercion coerces to string instead of number#23046
Open
zyuiop wants to merge 1 commit into
Open
Conversation
…oercion instead of string_numeric_coercion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Aligns the behavior of coercion with
type_union_coercion.In an union of types containing both Int and String, String is a better type as all Int can be cast to String, but not all String can be cast to Int.
What changes are included in this PR?
When coercing an union that contains both strings and ints, coerce to string instead of int.
Are these changes tested?
Covered by existing tests I assume
Are there any user-facing changes?