Improve performance of binary and string concatenation operator#23057
Draft
pepijnve wants to merge 2 commits into
Draft
Improve performance of binary and string concatenation operator#23057pepijnve wants to merge 2 commits into
pepijnve wants to merge 2 commits into
Conversation
comphead
reviewed
Jun 20, 2026
comphead
left a comment
Contributor
There was a problem hiding this comment.
Thanks @pepijnve
Lets wait apache/arrow-rs#10161 to be merged, the PR might get some changes down the road and we can port changes here.
It would be useful to have some TODO to use the arrow-rs code instead, once it is released
Contributor
Author
|
I'll mark this one as draft for now and add the TODO already. |
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
During recent profiling work string concatenation proved to be a hotspot. Investigation of the current kernel implementation for string views showed that there was still some room for improvement.
Together this can result in ~30% improvement per the string concat benchmark
Note that this work is a port of apache/arrow-rs#10161. Ideally the implementation from Arrow is used by DataFusion once the PR in that project is merged and released. Since DataFusion currently uses a custom kernel it seemed to make sense to temporarily port the proposed PR from Arrow.
What changes are included in this PR?
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No