fix(sql): preserve source qualifiers in CTAS with explicit schema#23879
Open
lyne7-sc wants to merge 2 commits into
Open
fix(sql): preserve source qualifiers in CTAS with explicit schema#23879lyne7-sc wants to merge 2 commits into
lyne7-sc wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23879 +/- ##
==========================================
- Coverage 80.75% 80.65% -0.11%
==========================================
Files 1089 1091 +2
Lines 368809 371031 +2222
Branches 368809 371031 +2222
==========================================
+ Hits 297837 299244 +1407
- Misses 53217 53940 +723
- Partials 17755 17847 +92 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
CTAS with an explicit schema fails when qualified source columns have the same name because their qualifiers are not preserved.
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
This is a bug fix with no public API changes.