perf: optimize spark soundex function#23909
Open
kazantsev-maksim wants to merge 3 commits into
Open
Conversation
added 2 commits
July 26, 2026 20:33
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23909 +/- ##
==========================================
- Coverage 80.65% 80.65% -0.01%
==========================================
Files 1093 1093
Lines 371619 371671 +52
Branches 371619 371671 +52
==========================================
+ Hits 299730 299756 +26
- Misses 53993 54017 +24
- Partials 17896 17898 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
There is another soundex optimization PR open. #23880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Optimize existing expression.
What changes are included in this PR?
unsafe { std::str::from_utf8_unchecked(&buf).to_string() }, resulting in zero heap allocations for code formatting.Are these changes tested?
Existing tests.
Benchmark (criterion):
Are there any user-facing changes?
No