minor(test): strengthen bitwise sort-merge join spill coverage - #24192
Open
buraksenn wants to merge 3 commits into
Open
minor(test): strengthen bitwise sort-merge join spill coverage#24192buraksenn wants to merge 3 commits into
buraksenn wants to merge 3 commits into
Conversation
…pill # Conflicts: # datafusion/physical-plan/src/joins/sort_merge_join/tests.rs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24192 +/- ##
=======================================
Coverage 81.05% 81.05%
=======================================
Files 1106 1106
Lines 382287 382287
Branches 382287 382287
=======================================
+ Hits 309851 309854 +3
+ Misses 54121 54116 -5
- Partials 18315 18317 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Continuing the work after #23988 and #24056.
BitwiseSortMergeJoinStream(filtered semi/anti/mark joins) buffers the inner key group and spills it under memory pressure, but existing tests only cover the successful spill path:NullEqualsNull, so NULL-key group boundary detection through the spill path was untestedWhat changes are included in this PR?
bitwise_filtered_no_spill: all six semi/anti/mark join types must surface a clear "Disk spilling disabled" error (not spill or panic) when the pool is exhausted with theDiskManagerdisabledbitwise_multi_spill_inner_key_groupoverLeftAnti/LeftMark, asserting the mark column valuebitwise_spill_null_key_group: underNullEqualsNull, a NULL-key group spanning a batch boundary must spill as one group with one spill file and match a NULL-key outer rowbitwise_spill_with_filterinto a fixtureAre these changes tested?
test only change and it can be tested via:
Are there any user-facing changes?
no test only change