Skip to content

test: add UnionArray hashing SQL coverage. - #24199

Merged
Jefffrey merged 1 commit into
apache:mainfrom
VaibhaveS:vsekar/add-union-hashing-tests
Aug 10, 2026
Merged

test: add UnionArray hashing SQL coverage.#24199
Jefffrey merged 1 commit into
apache:mainfrom
VaibhaveS:vsekar/add-union-hashing-tests

Conversation

@VaibhaveS

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Add regression coverage for SQL operations on UnionArray columns.

What changes are included in this PR?

Adds SQL logic tests for grouping, distinct, and aggregation on UnionArray columns.

Are these changes tested?

Yes. The focused SQL logic test passes:

cargo test --profile=ci --test sqllogictests -- union_function.slt

Are there any user-facing changes?

No.

@github-actions github-actions Bot added the sqllogictest SQL Logic Tests (.slt) label Aug 9, 2026
@Jefffrey

Jefffrey commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

it would be good to ensure the input dataset can actually represent the operations being done; the current input table being used only has 3 rows, all distinct, so technically theres no guarantee any of the hashing is working properly for distinct values

@VaibhaveS
VaibhaveS force-pushed the vsekar/add-union-hashing-tests branch from 12dbb63 to 85ea34e Compare August 9, 2026 06:32
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.06%. Comparing base (abc5ce7) to head (85ea34e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24199      +/-   ##
==========================================
+ Coverage   81.05%   81.06%   +0.01%     
==========================================
  Files        1106     1106              
  Lines      382398   381850     -548     
  Branches   382398   381850     -548     
==========================================
- Hits       309938   309534     -404     
+ Misses      54149    54040     -109     
+ Partials    18311    18276      -35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jefffrey
Jefffrey added this pull request to the merge queue Aug 10, 2026
@Jefffrey

Copy link
Copy Markdown
Contributor

thanks @VaibhaveS

Merged via the queue into apache:main with commit 7e66fdd Aug 10, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add UnionArray tests exercising hashing, group-by, distinct, and aggregates

3 participants