test: add UnionArray hashing SQL coverage. - #24199
Merged
Merged
Conversation
Contributor
|
it would be good to ensure the input dataset can actually represent the operations being done; the current input table being used only has 3 rows, all distinct, so technically theres no guarantee any of the hashing is working properly for distinct values |
VaibhaveS
force-pushed
the
vsekar/add-union-hashing-tests
branch
from
August 9, 2026 06:32
12dbb63 to
85ea34e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24199 +/- ##
==========================================
+ Coverage 81.05% 81.06% +0.01%
==========================================
Files 1106 1106
Lines 382398 381850 -548
Branches 382398 381850 -548
==========================================
- Hits 309938 309534 -404
+ Misses 54149 54040 -109
+ Partials 18311 18276 -35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jefffrey
approved these changes
Aug 10, 2026
Contributor
|
thanks @VaibhaveS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
UnionArraytests exercising hashing, group-by, distinct, and aggregates #18791.Rationale for this change
Add regression coverage for SQL operations on UnionArray columns.
What changes are included in this PR?
Adds SQL logic tests for grouping, distinct, and aggregation on UnionArray columns.
Are these changes tested?
Yes. The focused SQL logic test passes:
cargo test --profile=ci --test sqllogictests -- union_function.sltAre there any user-facing changes?
No.