Skip to content

[fix](orc) handle legacy calendar rebasing#396

Draft
xylaaaaa wants to merge 1 commit into
apache:orcfrom
xylaaaaa:codex/orc-legacy-calendar
Draft

[fix](orc) handle legacy calendar rebasing#396
xylaaaaa wants to merge 1 commit into
apache:orcfrom
xylaaaaa:codex/orc-legacy-calendar

Conversation

@xylaaaaa

Copy link
Copy Markdown

Summary

  • Add hybrid/proleptic Gregorian calendar conversion for ORC DATE and TIMESTAMP reads.
  • Detect writer calendar metadata and expose reader target calendar options.
  • Rebase DATE/TIMESTAMP predicate min/max safely and skip bloom filters when legacy/proleptic calendars differ.
  • Mark C++ ORC writer output as PROLEPTIC_GREGORIAN.

Test Plan

  • g++ -std=c++17 -Icontrib/apache-orc/c++/src -fsyntax-only contrib/apache-orc/c++/src/DateUtils.cc
  • cmake --build contrib/apache-orc/build_codex_orc_calendar_tp2 --target orc -j4
  • contrib/apache-orc/build_codex_orc_calendar_tp2/verify_orc_calendar
  • contrib/apache-orc/build_codex_orc_calendar_tp2/verify_orc_predicate_calendar
  • contrib/apache-orc/build_codex_orc_calendar_tp2/verify_orc_writer_calendar

Notes

  • Full orc-test is currently blocked by an existing unrelated TestBloomFilter private-member compile issue in this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant