[Opt](lambda) Aviod redundant copies during lambda execute - #66590
Open
linrrzqqq wants to merge 1 commit into
Open
[Opt](lambda) Aviod redundant copies during lambda execute#66590linrrzqqq wants to merge 1 commit into
linrrzqqq wants to merge 1 commit into
Conversation
linrrzqqq
force-pushed
the
opt-array-map
branch
from
August 8, 2026 07:27
3d14794 to
86e0aea
Compare
Collaborator
Author
|
/review |
Contributor
|
Codex automated review failed and did not complete. Error: Your access token could not be refreshed because your refresh token was already used. Please log out and sign in again. Please inspect the workflow logs and rerun the review after the underlying issue is resolved. |
Collaborator
Author
|
@linrrzqqq review |
linrrzqqq
commented
Aug 8, 2026
linrrzqqq
left a comment
Collaborator
Author
There was a problem hiding this comment.
Rarion independent review completed and converged.
No findings.
This result is based on an independent static code review. No builds or tests were run; refer to CI for test status.
Collaborator
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
array_mapflattens array elements into an internal block before executing its lambda expression. The previous implementation introduced several redundant copies and materializations on this path:These operations increased CPU usage and peak memory consumption, especially for large arrays, wide captured inputs, and complex lambda expressions.
This change optimizes the
array_mapexecution path by:ColumnConst.ColumnNothing.The optimization preserves array element order, nullable semantics, captured-column mapping, nested lambda behavior, and SQL result compatibility.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)