minor: Add metrics to costBased auto-scaler#19631
Merged
Merged
Conversation
kfaraz
commented
Jun 26, 2026
|
|
||
| At every evaluation interval, Druid computes the score for each candidate task count and picks the one with the lowest total cost. | ||
|
|
||
| Note: Kinesis is not supported yet, support is in progress. |
kfaraz
commented
Jun 26, 2026
| this.scaleDownDuringTaskRolloverOnly = Configs.valueOrDefault(scaleDownDuringTaskRolloverOnly, false); | ||
|
|
||
| if (this.enableTaskAutoScaler) { | ||
| if (useTaskCountBoundaries != null) { |
Contributor
Author
There was a problem hiding this comment.
Since this is a relatively new auto-scaler, we need not carry forward discontinued parameters for logging purposes as it adds to clutter.
Fly-Style
approved these changes
Jun 26, 2026
Contributor
Author
|
Thanks for the review, @Fly-Style ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
task/autoScaler/costBased/avgProcessingRatetask/autoScaler/costBased/avgPollIdleRatiotask/autoScaler/costBased/lagWeighttask/autoScaler/costBased/costWeighttask/autoScaler/costBased/lagCostsince it did not add value in identifying why a decision was takentask/autoScaler/costBased/idleCostsince it did not add value in identifying why a decision was takenThis PR has: