Skip to content

fix: resolve method descriptor return early matching logic #16330#16346

Open
LI123456mo wants to merge 1 commit into
apache:3.3from
LI123456mo:fixes-return-on-isGeneric-block-#16330
Open

fix: resolve method descriptor return early matching logic #16330#16346
LI123456mo wants to merge 1 commit into
apache:3.3from
LI123456mo:fixes-return-on-isGeneric-block-#16330

Conversation

@LI123456mo

Copy link
Copy Markdown
Contributor

What is the purpose of the change?

Checklist

  • This PR focuses on early return if the the method is "isGeneric()" instead of waiting the final return , which is consistent with the "isEcho()"

@codecov-commenter

codecov-commenter commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.79%. Comparing base (866860d) to head (b903ac2).

Files with missing lines Patch % Lines
...apache/dubbo/rpc/protocol/tri/DescriptorUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #16346      +/-   ##
============================================
- Coverage     60.80%   60.79%   -0.02%     
- Complexity       15    11769   +11754     
============================================
  Files          1953     1953              
  Lines         89208    89208              
  Branches      13458    13458              
============================================
- Hits          54245    54236       -9     
- Misses        29397    29405       +8     
- Partials       5566     5567       +1     
Flag Coverage Δ
integration-tests-java21 32.17% <0.00%> (+0.06%) ⬆️
integration-tests-java8 32.30% <0.00%> (+<0.01%) ⬆️
samples-tests-java21 32.17% <0.00%> (-0.02%) ⬇️
samples-tests-java8 29.85% <0.00%> (+0.12%) ⬆️
unit-tests-java11 59.05% <0.00%> (+0.02%) ⬆️
unit-tests-java17 58.50% <0.00%> (-0.02%) ⬇️
unit-tests-java21 58.49% <0.00%> (-0.01%) ⬇️
unit-tests-java25 58.49% <0.00%> (+0.04%) ⬆️
unit-tests-java8 59.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants