[validate]Disable active checkpoint trigger fix to demonstrate test failure #28347
Open
Samrat002 wants to merge 1 commit into
Open
[validate]Disable active checkpoint trigger fix to demonstrate test failure #28347Samrat002 wants to merge 1 commit into
Samrat002 wants to merge 1 commit into
Conversation
…failure Per Piotr's review on PR apache#27921: prove testRescaleWithActiveCheckpointTrigger fails in the expected way without the fix. - Cherry-picks the FLINK-36753 commit so the new config option, interface method, callbacks, and test compile. - Neutralises Executing.requestActiveCheckpointTrigger() to a no-op so the scheduler behaves as pre-fix: it never actively triggers a checkpoint to open the rescale gate. - Adds @timeout(60s) so the test fails fast instead of hanging forever (CommonTestUtils.waitUntilCondition has no default deadline). Expected outcome: the test times out waiting for the parallelism to drop from 4 to 3, because with a 24h checkpoint interval and no active trigger, no checkpoint ever completes to unblock the rescale. NOT FOR MERGE.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prove testRescaleWithActiveCheckpointTrigger fails in the expected way without the fix.
Expected outcome: the test times out waiting for the parallelism to drop from 4 to 3, because with a 24h checkpoint interval and no active trigger, no checkpoint ever completes to unblock the rescale.
NOT FOR MERGE.