[hotfix][ci] Do not run GHA nightly if there is no newer commits since the last run#28348
Open
snuyanzin wants to merge 2 commits into
Open
[hotfix][ci] Do not run GHA nightly if there is no newer commits since the last run#28348snuyanzin wants to merge 2 commits into
snuyanzin wants to merge 2 commits into
Conversation
Collaborator
Comment on lines
+54
to
+55
| // if it is same, then no need to run nightly for the same SHA again. | ||
| const { data: runsData } = await github.rest.actions.listWorkflowRuns({ |
Contributor
There was a problem hiding this comment.
Unless the nightly previously failed I guess? Then I think we'd like to run it again?
Contributor
Author
There was a problem hiding this comment.
this probably makes sense
initially I thought to skip it anyway, however on the other side it might help with flaky tests
added such condition as well
Contributor
Author
|
@flinkbot run azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The PR makes nightly running only if there are new commits since previous run.
If there is no new commits it will not run.
This is will allow to reduce GHA usage since Apache Infra is not happy with current usage
Brief change log
GHA
Verifying this change
GHA
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation
Was generative AI tooling used to co-author this PR?