[FLINK-39879][tests] Stop CheckpointAcknowledgeFailureITCase hanging on slow CI#28351
Open
MartijnVisser wants to merge 1 commit into
Open
[FLINK-39879][tests] Stop CheckpointAcknowledgeFailureITCase hanging on slow CI#28351MartijnVisser wants to merge 1 commit into
MartijnVisser wants to merge 1 commit into
Conversation
…on slow CI The test waited on an unbounded future that never completes when the tiny pekko.ask.timeout (load-bearing for the AskTimeoutException assertion) fails the job before the keyed state is updated, hanging the surefire fork until the CI watchdog kills it. Propagate a terminal job failure into the wait so the test fails fast with the real cause, and add @timeout(5, MINUTES) as the hard anti-hang guard. The product-side follow-up is tracked as FLINK-39738. Generated-by: Claude Opus 4.8 (1M context)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
CheckpointAcknowledgeFailureITCase.testCheckpointAckFailurecan hang the entire surefire fork on a slow CI machine until the 900s no-output watchdog kills it (observed onmaster, build 75716). The test sets a deliberately tinypekko.ask.timeoutso the oversized checkpoint-ACK RPC times out (load-bearing for theAskTimeoutExceptionassertion), but that timeout applies to every cluster RPC. On a slow agent an unrelated RPC (e.g. task deployment) can time out and fail the job terminally before the keyed state is updated, so the future the test waits on never completes and the unbounded wait wedges the fork.This makes the wait fail fast with the real cause and adds a hard timeout so the test can never hang a fork again. It is a test-only stabilization; the assertion is unchanged.
Brief change log
stateUpdatedFuturevia awhenCompletehandler ongetJobExecutionResult()(unwrapping theCompletionExceptionto the real cause), so the wait fails fast instead of blocking forever.executeJobAsyncnow returns theJobClientso the test can observe job termination.@Timeout(5, MINUTES)as the hard anti-hang guard (consistent withApproximateLocalRecoveryDownstreamITCasein the same package).Verifying this change
This change is a test stabilization of an existing test; the assertion (
triggerCheckpoint(...)must throwCheckpointExceptioncaused byAskTimeoutException) is unchanged. Verified locally:mvn -pl flink-tests -Dtest=CheckpointAcknowledgeFailureITCase test→Tests run: 1, Failures: 0.JobExecutionExceptioninstead of hanging until the watchdog kill.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.8 (1M context)