[rust] Add version-aware integration test harness (0.9.x / 1.x)#632
[rust] Add version-aware integration test harness (0.9.x / 1.x)#632gnuhpc wants to merge 4 commits into
Conversation
5b2ce66 to
003548f
Compare
|
Rebased on top of updated #631. Test fixtures migrated from Verified against real Java Fluss 0.9.1-incubating (68/68 tests pass without |
003548f to
5b79a57
Compare
|
Updated integration tests to use domain enums ( |
fdb66ef to
6a808db
Compare
|
@gnuhpc Can you,pls, rebase/cherry pick against current main, so I can review? |
- Replace raw SERVER_TAG_TEMPORARY_OFFLINE const with ServerTag::TemporaryOffline - Add readable parameter to get_lake_snapshot call Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pass `None` for the new `comment` parameter to keep round-2 reviewer-fix commits self-contained on each PR branch. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
After round 2's ClusterHealthStatus enum change, the variant is already validated by try_from_i32 on deserialisation, making the `>= 0` check redundant. Removing it also fixes a fluss_v1-feature-only compile error (comparing enum with integer). The remaining `.expect()` still proves the call succeeded. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
7f0445c to
d1d08f5
Compare
|
Rebased onto main. Should be clean for review now. |
fresh-borzoni
left a comment
There was a problem hiding this comment.
Thank you for the PR, I think it makes sense to use current image of the server instead of gating in general.
But for this we need to wait for merging fluss-rust into fluss main repo, I added this in the merge PR: apache/fluss#3401
Let's park it for now, I'll try to get a decision/timeline for this this week at the community call.
What
Adds an integration-test harness and tests for the 1.x admin surface:
Cargo.toml:integration_tests+fluss_v1feature flags (the latter gates tests exercising APIs only on 1.x servers).admin_extended.rs: end-to-end tests for the extended admin methods (ACLs, cluster configs, rebalance, server tags, producer offsets, KV snapshots, table stats).admin_v1.rs: tests for the 1.x-only RPCs.test_fluss.rs: wires the new test modules.Tests tolerate
UnsupportedVersionso the same suite runs green against both 0.9.x and 1.x server images.Stack
Part 5/6, stacked on #631 → #630 → #629 → #628. All target
main.🤖 Generated with Claude Code