[server] Fix orphan segments after full truncation - #4013
Open
swuferhong wants to merge 2 commits into
Open
Conversation
Delete the previous active segment after opening its replacement at a different offset. Strengthen deletion assertions for all segment files and cover truncation below the first segment across restart so a higher-offset orphan cannot advance the recovered LEO. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5 Co-Authored-By: Qoder <noreply@qoder.com> AI-Contributed/Feature: 2/2 AI-Contributed/UT: 54/54
swuferhong
force-pushed
the
truncate-error-fix
branch
2 times, most recently
from
August 17, 2026 03:59
3e3b599 to
b9b2f03
Compare
Rebuild writer state from persisted batches without applying online sequence validation. Warn about discontinuities for observability and verify that the recovered state survives another restart. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5 AI-Contributed/Feature: 5/5 AI-Contributed/UT: 0/0
swuferhong
force-pushed
the
truncate-error-fix
branch
from
August 17, 2026 04:04
b9b2f03 to
2efe41f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4012
[server] Fix orphan segments after full truncation:Delete the previous active segment after creating its replacement. Add regression coverage for upward and downward truncation to ensure stale segment files cannot affect the recovered log end offset.
[server] Tolerate sequence gaps during writer recovery:Rebuild writer state from persisted batches without applying online sequence validation. Warn about discontinuities for observability and verify that the recovered state survives another restart.
Brief change log
Tests
API and Format
Documentation