HIVE-26368: DISTINCT keyword from Count UDF is removed from query pla…#6582
Open
soumyakanti3578 wants to merge 1 commit into
Open
HIVE-26368: DISTINCT keyword from Count UDF is removed from query pla…#6582soumyakanti3578 wants to merge 1 commit into
soumyakanti3578 wants to merge 1 commit into
Conversation
…n when CBO is enabled
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



…n when CBO is enabled
What changes were proposed in this pull request?
Add a check in
HiveExpandDistinctAggregatesRuleand return early if there are multiple columns in aCOUNT DISTINCTWhy are the changes needed?
Otherwise the rule removes
DISTINCTfrom theCOUNT, and when theCOUNTis over multiple columns,GenericUDAFCountexpects aDISTINCT(which is also semantically right).Does this PR introduce any user-facing change?
No
How was this patch tested?