HIVE-29713 : maintain properties package, update JEXL dependency to JEXL 3.7.0#6592
Open
henrib wants to merge 4 commits into
Open
HIVE-29713 : maintain properties package, update JEXL dependency to JEXL 3.7.0#6592henrib wants to merge 4 commits into
henrib wants to merge 4 commits into
Conversation
… update property management documentation; - Updates JEXL dependency to 3.7.0
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs maintenance on the standalone metastore “properties” package and updates the Apache Commons JEXL dependency to 3.7.0, alongside small code modernizations and documentation additions to make the properties subsystem easier to understand and maintain.
Changes:
- Bump Apache Commons JEXL dependency to 3.7.0 and adjust JEXL engine initialization accordingly.
- Modernize/cleanup properties package code (e.g., Java 21 language features,
@Serialannotation). - Add new top-level documentation for the properties package and refresh/adjust existing Javadocs.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| standalone-metastore/pom.xml | Updates the JEXL version property to 3.7.0. |
| standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/properties/SerializationProxy.java | Adds @Serial annotation for serialVersionUID. |
| standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/properties/PropertyType.java | Refactors casts using pattern matching for instanceof. |
| standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/properties/PropertyStore.java | Javadoc refresh (notably around bulk save semantics). |
| standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/properties/PropertyMap.java | Minor Javadoc correction in the deserialization constructor comment. |
| standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/properties/PropertyManager.java | Updates JEXL feature initialization for compatibility with newer JEXL. |
| standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/properties/HMSPropertyManager.java | Updates documentation and maintenance-operation enums; modernizes switch usage. |
| PROPERTIES_PACKAGE.md | Adds new package-level documentation and usage examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
okumin
reviewed
Jul 14, 2026
Comment on lines
+40
to
+41
| * A potential extension would be to add maintenance operation properties at the cluster and database levels to the schema | ||
| * so they could act as default values for table properties used by maintenance operations. |
Contributor
There was a problem hiding this comment.
Suggested change
| * A potential extension would be to add maintenance operation properties at the cluster and database levels to the schema | |
| * so they could act as default values for table properties used by maintenance operations. | |
| * A potential extension would be to add maintenance operation properties at the cluster and database levels to the | |
| * schema so they could act as default values for table properties used by maintenance operations. |
Just for the 120-characters rule
| * <li>db.table.name : when it refers to a table property named 'name' for the table 'table' in the database 'db'</li> | ||
| * </ul> | ||
| * <p> | ||
| * This is meant as the base of a property manager that could be used to manage properties in the HiveMetaStore |
Contributor
There was a problem hiding this comment.
I am just curious about the future vision stated here
| REWRITE_MANIFEST, | ||
| DELETE_ORPHAN_FILES, | ||
| REWRITE_POSITION_DELETE, | ||
| COMPUTE_TABLE_STATS |
Contributor
There was a problem hiding this comment.
Could you explain the enum changes? I understand we can change them as the original values are not used yet. However, I am not confident about why the new values are better than the old ones. One option is to separate the PR and involve Dmitriy or someone more familiar with maintenance tasks there. I can quickly give you +1 for the JEXL upgrade, but I may need to learn something to approve this list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The properties package needed a bit of refresh and some documentation.
JEXL version needed an update.
Why are the changes needed?
Proactive maintenance especially wrt JEXL / security.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests