Skip to content

http2: honor H2WindowSize as stream window floor #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Witaminer wants to merge 1 commit into
base: trunk
Choose a base branch
from
+17 −6
Open

http2: honor H2WindowSize as stream window floor #710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions modules/http2/h2_stream.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,12 +1341,23 @@ apr_status_t h2_stream_in_consumed(h2_stream *stream, apr_off_t amount)
int cur_size = nghttp2_session_get_stream_local_window_size(
session->ngh2, stream->id);
int win = stream->in_window_size;
int thigh = win * 8/10;
int tlow = win * 2/10;
const int win_max = 2*1024*1024;
const int win_min = 32*1024;

/* Work in progress, probably should add directives for these
const int win_min = h2_config_sgeti(session->s, H2_CONF_WIN_SIZE);
const int win_max = (win_min <= NGHTTP2_MAX_WINDOW_SIZE / 2)?
win_min * 2 : NGHTTP2_MAX_WINDOW_SIZE;

if (win < win_min) {
win = win_min;
}

int thigh = (int)(((apr_int64_t)win * 8) / 10);
int tlow = (int)(((apr_int64_t)win * 2) / 10);

/* H2WindowSize is the configured receive window and acts as
* the lower bound for adaptive stream window sizing. This also
* prevents the tuner from getting stuck at a much smaller value.
*/

/* Work in progress, probably should add directives for these
* values once this stabilizes somewhat. The general idea is
* to adapt stream window sizes if the input window changes
* a) very quickly (< good RTT) from full to empty
Expand Down