fix(ci): modernize Codecov uploads - #3169
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3169 +/- ##
=============================================
- Coverage 51.16% 37.44% -13.72%
- Complexity 264 6448 +6184
=============================================
Files 534 800 +266
Lines 50665 68595 +17930
Branches 7129 9100 +1971
=============================================
- Hits 25923 25687 -236
- Misses 21979 39894 +17915
- Partials 2763 3014 +251 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
imbajin
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The Codecov action upgrade is directionally correct, but this head is not merge-ready after #3161 because it still uses incorrect or over-broad report inputs. Evidence: exact-head jobs 97408972447, 97408972425, and 97406468118 reported missing explicit files and then uploaded unrelated reports; the PR is also currently conflicting with master.
41a60f2 to
325948d
Compare
- accept quoted action refs and inline comments - bind report paths to workflow job IDs - allow harmless job declaration reordering
imbajin
left a comment
There was a problem hiding this comment.
Verified exact head 424cbc9. All required CI checks pass, and Codecov accepted all 7 expected v5 upload sessions (Commons, PD, Store, HStore, and 3 Server backends); each resolved one explicit report and completed without HTTP 429, missing-file, or upload errors. The red project status (37.44% vs 51.16%) is caused by comparing the complete 7-session head report with an incomplete 3-session base report, not by a missing head upload. Patch coverage is unaffected. Coverage thresholds and JaCoCo aggregation remain outside #3168's scope.
Purpose of the PR
HugeGraph still uses
codecov/codecov-action@v3for Commons,PD/Store/HStore, and Server coverage uploads. Fork pull requests cannot access
CODECOV_TOKEN, so v3 falls back to the legacy anonymous uploader. Thatuploader shares a global rate limit: HTTP 429 failures were observed on #3167
and #3161, while the uploader still exited with status 0 and left Codecov with
only a subset of the expected reports.
This PR modernizes the upload boundary only. It does not change JaCoCo
collection, aggregation, coverage thresholds, or production code. The
PD/Store report aggregation work remains independent in #3160 and #3161.
Main Changes
codecov/codecov-action@v3to@v5.CODECOV_TOKENfor trusted push and same-repository runs.On fork pull requests the secret remains unavailable by design, and v5 uses
its fork-aware tokenless upload path.
fileinput withfilesin every upload step.actions, missing
filesinputs, missing trusted-run token inputs, removedexpected uploads, and newly added legacy upload steps.
add
fail_ci_if_error: true.Verifying these changes
bash hugegraph-server/hugegraph-dist/src/assembly/travis/test-codecov-upload-config.shmvn -q apache-rat:check -N -ntpmvn editorconfig:check -pl hugegraph-server/hugegraph-dist -am -ntpgit diff --checkafter all five upload steps were migrated.
added workflow and does not mistake
env.tokenforwith.token.The external upload result is intentionally left to this PR's GitHub Actions
run, which exercises the v5 fork-aware tokenless path that cannot be reproduced
as a local Codecov upload.
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need