fix(scan): reject missing column stats fields#759
Merged
Conversation
Member
|
Ah, I didn't notice this PR before my agent raised #786. By practice we should respect the 1st PR that works on the same issue. However I think this PR chose the wrong direction (changed the semantics of Schema::Select) and applied a more complex fix (relied on heavy call to Schema::Select for validation). Do you mind changing your PR to use the approach in #786? Then I can merge this one and close that one. |
Contributor
Author
|
Thank you @wgtmac, I will push the commit in a few hours. |
8840174 to
f14a1a9
Compare
Contributor
Author
wgtmac
approved these changes
Jun 30, 2026
Member
|
Thank you, @fallintoplace! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IncludeColumnStats()column names against the resolved snapshot schema during scan buildSchema::Select()and regular scan projection semantics unchangedTests
pre-commit run --all-filescmake --build build --target scan_testctest --test-dir build -R '^scan_test$' --output-on-failure