fix: allow historical sort orders with dropped fields#762
Merged
wgtmac merged 2 commits intoJun 23, 2026
Conversation
This fix is aligned with: apache/iceberg#16521
huan233usc
reviewed
Jun 22, 2026
|
|
||
| auto metadata = TableMetadataFromJson(metadata_json); | ||
| ASSERT_THAT(metadata, IsOk()); | ||
| ASSERT_EQ(metadata.value()->sort_orders.size(), 2); |
Contributor
There was a problem hiding this comment.
Can we assert the historical sort order still has two fields, including source_id() == 2? Otherwise this would still pass if the dropped-field sort term were skipped. A negative case where that order is the default sort order would also help verify default sort order validation is still strict.
Collaborator
Author
There was a problem hiding this comment.
Updated the tests to cover both preserving the dropped-field historical sort order and rejecting it as the default sort order.
zhjwpku
added
the
ready to review
wgtmac
removed
the
ready to review
wgtmac
approved these changes
Jun 23, 2026
Member
|
Thanks @zhjwpku for the fix and @huan233usc for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is aligned with:
apache/iceberg#16521