feat: Support UUID values across row and file IO#790
Merged
Conversation
huan233usc
reviewed
Jun 30, 2026
huan233usc
left a comment
huan233usc
left a comment
Contributor
There was a problem hiding this comment.
A few minor, non-blocking nits — otherwise LGTM.
| return std::nullopt; | ||
| } | ||
|
|
||
| constexpr std::array<uint8_t, Uuid::kLength> kUuidBytes1 = { |
Contributor
There was a problem hiding this comment.
kUuidBytes1/2 + MakeUuidArray are duplicated with avro_test.cc — consider a shared test util.
Collaborator
Author
There was a problem hiding this comment.
kUuidBytes1/2 are just random UUID values, adding a shared test util file might be overkill.
| SchemaField::MakeRequired(3, MapType::kValueName, iceberg::uuid())))}); | ||
|
|
||
| auto map_offsets = MakeInt32Array({0, 2, 3}); | ||
| auto map_keys = MakeStringArray({"first", "second", "only"}); |
Contributor
There was a problem hiding this comment.
Map key is a string here — the UUID-key path (StorageTypeForBuilder(key_type)) is untested; add a UUID-key case if Iceberg allows it.
Collaborator
Author
There was a problem hiding this comment.
Add a case, thanks.
huan233usc
approved these changes
Jun 30, 2026
wgtmac
approved these changes
Jul 1, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks @zhjwpku for working on it and @huan233usc for the review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #314