Flink: Resolve unpartitioned equality deletes across all partitions#17018
Open
mxm wants to merge 1 commit into
Open
Flink: Resolve unpartitioned equality deletes across all partitions#17018mxm wants to merge 1 commit into
mxm wants to merge 1 commit into
Conversation
The PK index keys rows by (spec id, equality values), so a delete only matches data written under the same spec. However, according to the Iceberg table spec, while a partitioned delete applies only within its own spec, an unpartitioned equality delete must apply across every spec. This change drops the spec id from the key, so all rows with the same equality values co-locate on one shard. We scope at resolve time instead: RESOLVE_DELETE carries the delete's spec id, or a GLOBAL_DELETE_SPEC_ID when the delete is unpartitioned. The index deletes a row only when the delete is global or the row's spec id matches. DVPosition already carries each row's spec id, so no extra row state is needed.
mxm
changed the title
mxm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PK index keys rows by (spec id, equality values), so a delete only matches data written under the same spec. However, according to the Iceberg table spec, while a partitioned delete applies only within its own spec, an unpartitioned equality delete must apply across every spec.
This change drops the spec id from the key, so all rows with the same equality values co-locate on one shard. We scope at resolve time instead: RESOLVE_DELETE carries the delete's spec id, or a GLOBAL_DELETE_SPEC_ID when the delete is unpartitioned. The index deletes a row only when the delete is global or the row's spec id matches. DVPosition already carries each row's spec id, so no extra row state is needed.