fix: check mayContainNulls in ParquetDictionaryRowGroupFilter.notStartsWith - #17682
Open
waterWang wants to merge 2 commits into
Open
fix: check mayContainNulls in ParquetDictionaryRowGroupFilter.notStartsWith#17682waterWang wants to merge 2 commits into
waterWang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17655
Problem
ParquetDictionaryRowGroupFilter.notStartsWithcan skip row groups that contain null values, silently dropping rows from scan results.The filter decides whether a row group can be skipped by inspecting only the column's dictionary. A Parquet dictionary contains non-null values only, so when every dictionary entry starts with the prefix the filter returns
ROWS_CANNOT_MATCH— even when the column also contains nulls.In Iceberg a null value matches
notStartsWith:Evaluatorimplements it as!startsWith(...), andstartsWithevaluates to false for null. A row group holding nulls therefore does contain matching rows and must not be skipped.Fix
Add a
mayContainNullscheck tonotStartsWith, consistent with hownotEq,notIn, andnotNaNalready handle null-containing row groups.Changes
ParquetDictionaryRowGroupFilter.java: Addedif (mayContainNulls.get(id)) return ROWS_MIGHT_MATCH;innotStartsWith, matching the pattern used bynotNaN.TestDictionaryRowGroupFilter.java: Updated the assertion fornotStartsWith("some_nulls", "some")fromisFalse()toisTrue()— this row group contains nulls, so it must be read.