fix: use getWithoutDefault to avoid Connect schema default for null values - #17684
Open
waterWang wants to merge 4 commits into
Open
fix: use getWithoutDefault to avoid Connect schema default for null values#17684waterWang wants to merge 4 commits into
waterWang wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17652
Problem
Kafka Connect's
Struct.get(Field)returns the field's schemadefaultValuewhen the stored value isnull, without checkingisOptional()(longstanding Connect behavior, see KAFKA-8713). The Iceberg sink and its bundled SMTs read field values withget()in several places, so an explicitNULLin the source ends up written to the Iceberg table as the column's default value.The most common trigger is Debezium CDC: for any column that is nullable with a non-NULL default (e.g. MySQL
VARCHAR(255) NULL DEFAULT ''), every explicitly NULL value is replaced with the default.Fix
Replace
Struct.get(Field)withStruct.getWithoutDefault(String)at all affected call sites.getWithoutDefaultreturns the actual stored value without applying the schema default, so null values are preserved as null.Changes
DebeziumTransform.java— copy loop inapplyWithSchemaKafkaMetadataTransform.java— copy loop inapplyWithSchemaCopyValue.java— copy loop and single-field copy inapplyWithSchemaRecordConverter.java— field reads instructToIceberg,collectFieldNames, andstructToVariant