fix: support java.util.Date in RecordConverter.convertLong - #17690
Open
waterWang wants to merge 1 commit into
Open
fix: support java.util.Date in RecordConverter.convertLong#17690waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
When Confluent Avro converter deserializes timestamp-millis as java.util.Date, RecordConverter.convertLong() throws because it only handles Number and String. Add Date handling via getTime() to extract epoch millis. Fixes apache#15344
ebyhr
reviewed
Aug 18, 2026
ebyhr
left a comment
ebyhr
left a comment
Member
There was a problem hiding this comment.
Could you please update TestRecordConverter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15344
Problem
When using Confluent Avro converter, timestamp-millis fields are deserialized as
java.util.Dateobjects.RecordConverter.convertLong()only handlesNumberandString, causingIllegalArgumentException: Cannot convert to long: java.util.Date.Fix
Add
Datehandling toconvertLong()viaDate.getTime()to extract epoch millis, matching the existing pattern used byconvertDateValue,convertTimeValue,convertOffsetDateTime, andconvertLocalDateTimewhich all handleDate.Testing