API: Add tests for BinaryUtil - #17692
Open
uros-b wants to merge 2 commits into
Open
Conversation
Cover truncateBinary (partial, full, zero-length, and negative-length guard), the previously untested truncateBinaryUnsafe view, and truncateBinaryMax including the all-bytes-overflow case.
Member
Author
|
@nastra Please review |
nastra
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a unit test class for
BinaryUtil, covering its public truncation helpers:truncateBinary- truncation to a shorter length, the fast path that returns the input buffer unchanged when the requested length already covers it, zero-length truncation, and the non-negative-length precondition.truncateBinaryUnsafe- the shared-backing-data view, and that the input buffer's position and limit are left unmodified.truncateBinaryMin- theByteBufferoverload, and theLiteraloverload including its distinct branch that returns the inputLiteralunchanged when the length already covers the value.truncateBinaryMax- theByteBufferoverload (incrementing the last byte to form the upper bound, and returningnullwhen every byte overflows, all0xFF), and theLiteraloverload including its propagation of thatnullresult.Test-only; no production code changes.