Skip to content

Build: Remove unused Avro dependency from iceberg-orc - #17694

Merged
szehon-ho merged 1 commit into
apache:mainfrom
uros-b:build-remove-unused-avro-orc
Aug 18, 2026
Merged

Build: Remove unused Avro dependency from iceberg-orc#17694
szehon-ho merged 1 commit into
apache:mainfrom
uros-b:build-remove-unused-avro-orc

Conversation

@uros-b

@uros-b uros-b commented Aug 17, 2026

Copy link
Copy Markdown
Member

iceberg-orc declares a direct implementation dependency on Avro, but the module does not reference any Avro classes, there is no org.apache.avro.* or org.apache.iceberg.avro.* usage anywhere under orc/src. The palantir checkUnusedDependencies baseline also reports it as unused. Avro remains available transitively where needed: iceberg-core (which iceberg-orc depends on) declares Avro as an api dependency, so dropping this redundant direct declaration does not change any module's compile or runtime classpath. Build-only; no source changes. iceberg-orc compiles and its tests pass with the dependency removed.

The iceberg-orc module declares an implementation dependency on Avro but does not reference any Avro classes; the palantir checkUnusedDependencies baseline confirms it is unused.
@github-actions github-actions Bot added the build label Aug 17, 2026

@uros-b uros-b left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fokko Please review.

@uros-b

uros-b commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

cc @szehon-ho

@szehon-ho
szehon-ho merged commit 96373ad into apache:main Aug 18, 2026
39 checks passed
@szehon-ho

szehon-ho commented Aug 18, 2026

Copy link
Copy Markdown
Member

Makes sense to me, merged, thanks @uros-b , and @ebyhr for additional review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants