Core: Remove deprecated DataReader in favor of PlannedDataReader - #17699
Open
dramaticlly wants to merge 1 commit into
Open
Core: Remove deprecated DataReader in favor of PlannedDataReader#17699dramaticlly wants to merge 1 commit into
dramaticlly wants to merge 1 commit into
Conversation
DataReader was deprecated for removal in 1.12.0; PlannedDataReader is the replacement. Also removes the deprecated RawDecoder constructor that took a read schema and reader function, superseded by RawDecoder.create(Schema, Function, Schema). No remaining references to either. TestDataReader is removed along with the class it covered; PlannedDataReader has its own coverage in TestPlannedDataReader.
Contributor
Author
|
@gaborkaszab can you help check for removal match the expectation of #14387 |
nastra
approved these changes
Aug 18, 2026
uros-b
approved these changes
Aug 18, 2026
Member
|
+1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Avro read paths deprecated for removal in 1.12.0:
org.apache.iceberg.data.avro.DataReader(class) →PlannedDataReaderRawDecoder(Schema, Function<Schema, DatumReader<?>>, Schema)→RawDecoder.create(Schema, Function, Schema)Neither has any remaining reference in main or test sources.
TestDataReaderis removed along with the class it covered;PlannedDataReaderhas its own coverage.Split out of #16449 to reduce reviewer burden.
AI Disclosure
Model: Claude Opus 5 (1M context)
Platform/Tool: Claude Code
Human Oversight: reviewed
Prompt Summary: split #16449 into smaller self-contained PRs; verify each group compiles and tests green standalone