Core: Remove deprecated methods and fields scheduled for 1.12.0 removal - #17700
Open
dramaticlly wants to merge 2 commits into
Open
Core: Remove deprecated methods and fields scheduled for 1.12.0 removal#17700dramaticlly wants to merge 2 commits into
dramaticlly wants to merge 2 commits into
Conversation
Removes the remaining core API marked for removal in 1.12.0 that has no callers left: - SystemProperties (class) -> SystemConfigs - ThreadPools.newWorkerPool(String) and newWorkerPool(String, int) -> newExitingWorkerPool or newFixedThreadPool depending on pool lifetime - ContentCache.invalidateAll(), which was only best-effort and racy - TableProperties.MANIFEST_LISTS_ENABLED and MANIFEST_LISTS_ENABLED_DEFAULT; writing manifest lists is always enabled - AvroSchemaUtil.pruneColumns(Schema, Set, NameMapping) -> applyNameMapping plus pruneColumns(Schema, Set) - SnapshotUtil.newFiles and newFilesBetween -> SnapshotChanges with ancestorsBetween - TableScanUtil.hasDeletes(CombinedScanTask) and hasEqDeletes(CombinedScanTask) - StandardEncryptionManager(String, int, KeyManagementClient), wrapKey and unwrapKey - ManifestFiles.read(ManifestFile, FileIO), readPaths(ManifestFile, FileIO) and open(ManifestFile, FileIO) -> the overloads taking a specs map - BaseScan.io() -> table().io(); DataScan and BaseDistributedDataScan are migrated to call table().io() directly
dramaticlly
commented
Aug 17, 2026
| private TableScanUtil() {} | ||
|
|
||
| /** | ||
| * @deprecated since 1.11.0 and will be removed in 1.12.0 |
Contributor
Author
|
@RussellSpitzer can you help check for ManifestFiles in #15575 and SnapshotUtil from #15656 |
manuzhang
reviewed
Aug 18, 2026
nastra
approved these changes
Aug 18, 2026
uros-b
approved these changes
Aug 18, 2026
Member
|
LGTM |
Member
|
@dramaticlly Please include a |
Contributor
@manuzhang I don't think we require this. Also our guidelines don't say that this must be included |
Member
|
@nastra Sure, I'm referring to ai-generated-pr-disclosure, which is not a hard requirement, of course. |
Contributor
ah interesting, I wasn't aware about this particular sentence. thanks for mentioning it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the remaining core API marked for removal in 1.12.0 that has no callers left. Each item is an independent deletion; grouping them keeps the review to one pass over one module rather than nine tiny PRs.
SystemProperties(class)SystemConfigsThreadPools.newWorkerPool(String),newWorkerPool(String, int)newExitingWorkerPoolfor long-lived pools,newFixedThreadPoolfor short-livedContentCache.invalidateAll()TableProperties.MANIFEST_LISTS_ENABLED,MANIFEST_LISTS_ENABLED_DEFAULTAvroSchemaUtil.pruneColumns(Schema, Set, NameMapping)applyNameMapping+pruneColumns(Schema, Set)SnapshotUtil.newFiles,newFilesBetweenSnapshotChangeswithancestorsBetweenTableScanUtil.hasDeletes(CombinedScanTask),hasEqDeletes(CombinedScanTask)FileScanTaskoverloadsStandardEncryptionManager(String, int, KeyManagementClient),wrapKey,unwrapKeyManifestFiles.read(ManifestFile, FileIO),readPaths(ManifestFile, FileIO),open(ManifestFile, FileIO)BaseScan.io()table().io()The only change that is not a pure deletion:
BaseScan.io()was aprotectedhelper, so its two subclass users are migrated to calltable().io()directly —DataScan(1 site) andBaseDistributedDataScan(3 sites). No engine module subclasses used it.AI Disclosure
Model: Claude Opus 5 (1M context)
Platform/Tool: Claude Code
Human Oversight: reviewed
Prompt Summary: split #16449 into smaller self-contained PRs; verify each group compiles and tests green standalone