Skip to content

refactor(consensus): remove namespace from client headers - #3836

Open
numinnex wants to merge 20 commits into
masterfrom
remove_namespace_field
Open

refactor(consensus): remove namespace from client headers#3836
numinnex wants to merge 20 commits into
masterfrom
remove_namespace_field

Conversation

@numinnex

@numinnex numinnex commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

numinnex and others added 13 commits August 3, 2026 12:19
Removing the namespace-exemption import left its #[cfg(debug_assertions)]
attribute orphaned onto the unconditional server_common import below it, so
every release build of the shard crate fails with 112 unresolved-name
errors. Debug builds keep the import and CI's -D warnings lane rides
clippy, which builds debug, so nothing upstream could observe it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 7, 2026
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.35928% with 198 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.24%. Comparing base (73802f8) to head (779ecaf).

Files with missing lines Patch % Lines
core/shard/src/lib.rs 47.16% 54 Missing and 2 partials ⚠️
core/server-ng/src/dispatch.rs 40.00% 33 Missing ⚠️
core/simulator/src/client.rs 65.27% 25 Missing ⚠️
core/metadata/src/impls/metadata.rs 70.66% 22 Missing ⚠️
core/binary_protocol/src/consensus/header.rs 87.34% 10 Missing ⚠️
core/partitions/src/state_transfer.rs 16.66% 5 Missing ⚠️
core/consensus/src/impls.rs 91.66% 4 Missing ⚠️
core/partitions/src/iggy_partitions.rs 75.00% 4 Missing ⚠️
core/shard/src/router.rs 75.00% 4 Missing ⚠️
core/partitions/src/iggy_partition.rs 85.71% 3 Missing ⚠️
... and 27 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3836      +/-   ##
============================================
- Coverage     76.95%   75.24%   -1.72%     
- Complexity     1021     1296     +275     
============================================
  Files          1366     1374       +8     
  Lines        176130   176381     +251     
  Branches     146172   146090      -82     
============================================
- Hits         135547   132712    -2835     
- Misses        36707    39745    +3038     
- Partials       3876     3924      +48     
Components Coverage Δ
Rust Core 75.91% <69.72%> (-0.16%) ⬇️
Java SDK 66.15% <ø> (+2.92%) ⬆️
C# SDK 40.95% <ø> (-35.06%) ⬇️
Python SDK 89.98% <ø> (ø)
PHP SDK 84.26% <ø> (ø)
Node SDK 96.25% <100.00%> (-0.08%) ⬇️
Go SDK 68.60% <100.00%> (-0.53%) ⬇️
Files with missing lines Coverage Δ
core/binary_protocol/src/namespace.rs 90.90% <ø> (ø)
core/binary_protocol/src/version.rs 99.22% <ø> (ø)
core/consensus/src/lib.rs 0.00% <ø> (ø)
core/consensus/src/observability.rs 40.08% <100.00%> (ø)
core/consensus/src/plane_helpers.rs 96.24% <100.00%> (-0.03%) ⬇️
core/server-ng/src/bootstrap.rs 24.89% <ø> (ø)
core/server-ng/src/http/session.rs 85.80% <ø> (ø)
core/server-ng/src/http/wire.rs 95.93% <100.00%> (ø)
core/server-ng/src/partition_reconciler.rs 93.02% <100.00%> (ø)
core/server-ng/src/responses.rs 41.10% <100.00%> (-0.05%) ⬇️
... and 59 more

... and 124 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mmodzelewski
mmodzelewski previously approved these changes Aug 8, 2026
spetz
spetz previously approved these changes Aug 8, 2026
@numinnex
numinnex dismissed stale reviews from spetz and mmodzelewski via 02b1937 August 8, 2026 06:37
@numinnex
numinnex marked this pull request as draft August 8, 2026 06:39
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Aug 8, 2026
@numinnex
numinnex marked this pull request as ready for review August 10, 2026 18:27
@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants