refactor(consensus): remove namespace from client headers - #3836
Open
numinnex wants to merge 20 commits into
Open
refactor(consensus): remove namespace from client headers#3836numinnex wants to merge 20 commits into
numinnex wants to merge 20 commits into
Conversation
Removing the namespace-exemption import left its #[cfg(debug_assertions)] attribute orphaned onto the unconditional server_common import below it, so every release build of the shard crate fails with 112 unresolved-name errors. Debug builds keep the import and CI's -D warnings lane rides clippy, which builds debug, so nothing upstream could observe it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3836 +/- ##
============================================
- Coverage 76.95% 75.24% -1.72%
- Complexity 1021 1296 +275
============================================
Files 1366 1374 +8
Lines 176130 176381 +251
Branches 146172 146090 -82
============================================
- Hits 135547 132712 -2835
- Misses 36707 39745 +3038
- Partials 3876 3924 +48
🚀 New features to boost your workflow:
|
mmodzelewski
previously approved these changes
Aug 8, 2026
spetz
previously approved these changes
Aug 8, 2026
numinnex
marked this pull request as ready for review
August 10, 2026 18:27
mmodzelewski
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.