Skip to content

refactor(csharp): cleanup tcp connection after vsr implementation - #3858

Open
lukaszzborek wants to merge 2 commits into
masterfrom
dotnet-vsr-cleanup
Open

refactor(csharp): cleanup tcp connection after vsr implementation#3858
lukaszzborek wants to merge 2 commits into
masterfrom
dotnet-vsr-cleanup

Conversation

@lukaszzborek

Copy link
Copy Markdown
Contributor

Follow-up cleanup of the .NET SDK TCP transport after the VSR support landed

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 10, 2026
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.05371% with 121 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.94%. Comparing base (a3e256b) to head (cbf8bfc).

Files with missing lines Patch % Lines
...SDK/IggyClient/Implementations/TcpMessageStream.cs 53.33% 48 Missing and 8 partials ⚠️
foreign/csharp/Iggy_SDK/Vsr/VsrConnection.cs 74.56% 36 Missing and 8 partials ⚠️
...IggyClient/Implementations/TcpMessageStream.Vsr.cs 58.82% 10 Missing and 4 partials ⚠️
foreign/csharp/Iggy_SDK/Vsr/VsrNamespace.cs 85.71% 2 Missing and 1 partial ⚠️
foreign/csharp/Iggy_SDK/Consumers/IggyConsumer.cs 95.23% 0 Missing and 1 partial ⚠️
foreign/csharp/Iggy_SDK/Mappers/BinaryMapper.cs 0.00% 1 Missing ⚠️
foreign/csharp/Iggy_SDK/Vsr/ConsensusSession.cs 83.33% 1 Missing ⚠️
foreign/csharp/Iggy_SDK/Vsr/VsrHeader.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3858      +/-   ##
============================================
- Coverage     76.95%   75.94%   -1.02%     
  Complexity     1021     1021              
============================================
  Files          1366     1367       +1     
  Lines        176130   176082      -48     
  Branches     146173   146287     +114     
============================================
- Hits         135547   133721    -1826     
- Misses        36707    38479    +1772     
- Partials       3876     3882       +6     
Components Coverage Δ
Rust Core 76.07% <ø> (ø)
Java SDK 63.22% <ø> (ø)
C# SDK 53.44% <69.05%> (-22.57%) ⬇️
Python SDK 89.98% <ø> (ø)
PHP SDK 84.26% <ø> (ø)
Node SDK 96.33% <ø> (ø)
Go SDK 69.13% <ø> (ø)
Files with missing lines Coverage Δ
foreign/csharp/Iggy_SDK/Utils/ArrayPoolHelper.cs 100.00% <100.00%> (ø)
...n/csharp/Iggy_SDK/Utils/TcpMessageStreamHelpers.cs 91.42% <ø> (+6.64%) ⬆️
foreign/csharp/Iggy_SDK/Consumers/IggyConsumer.cs 43.73% <95.23%> (-27.19%) ⬇️
foreign/csharp/Iggy_SDK/Mappers/BinaryMapper.cs 73.31% <0.00%> (-20.18%) ⬇️
foreign/csharp/Iggy_SDK/Vsr/ConsensusSession.cs 95.00% <83.33%> (-5.00%) ⬇️
foreign/csharp/Iggy_SDK/Vsr/VsrHeader.cs 94.91% <66.66%> (-1.70%) ⬇️
foreign/csharp/Iggy_SDK/Vsr/VsrNamespace.cs 96.94% <85.71%> (-3.06%) ⬇️
...IggyClient/Implementations/TcpMessageStream.Vsr.cs 60.63% <58.82%> (-14.57%) ⬇️
foreign/csharp/Iggy_SDK/Vsr/VsrConnection.cs 74.56% <74.56%> (ø)
...SDK/IggyClient/Implementations/TcpMessageStream.cs 48.50% <53.33%> (-31.90%) ⬇️

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukaszzborek

Copy link
Copy Markdown
Contributor Author

If possible, merge #3836 first. Then I will remove things with namespace which I refactoring 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants