refactor(csharp): cleanup tcp connection after vsr implementation - #3858
Open
lukaszzborek wants to merge 2 commits into
Open
refactor(csharp): cleanup tcp connection after vsr implementation#3858lukaszzborek wants to merge 2 commits into
lukaszzborek wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3858 +/- ##
============================================
- Coverage 76.95% 75.94% -1.02%
Complexity 1021 1021
============================================
Files 1366 1367 +1
Lines 176130 176082 -48
Branches 146173 146287 +114
============================================
- Hits 135547 133721 -1826
- Misses 36707 38479 +1772
- Partials 3876 3882 +6
🚀 New features to boost your workflow:
|
Contributor
Author
|
If possible, merge #3836 first. Then I will remove things with namespace which I refactoring 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup of the .NET SDK TCP transport after the VSR support landed