Pipe: Handle transient resource failures locally - #18381
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
jt2594838
reviewed
Aug 3, 2026
Comment on lines
+74
to
+80
| final Map<String, Long> sanitizedFailures = new HashMap<>(); | ||
| recentFailures.forEach( | ||
| (failureType, count) -> { | ||
| if (Objects.nonNull(failureType) && Objects.nonNull(count) && count > 0) { | ||
| sanitizedFailures.put(failureType, count); | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
What is the necessity of this step?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle transient resource failures locally
PipeStopStrategy.accept(Exception, TSStatus)as the shared decision point for sink failures.Expose recent resource failures
RecentFailuresto tree-modelSHOW PIPESandrecent_failurestoinformation_schema.pipes.{memory_timeout=15, network_timeout=10}, and render{}when empty.Compatibility and verification
The new Thrift fields are optional, so mixed-version heartbeats and show-pipe responses continue to parse without them.
Verified with:
git diff --checkThe updated
IoTDBDatabaseITassertion was compiled. Its targeted execution was attempted, but the reactor was stopped before reaching the integration test by host Windows page-file exhaustion in an unrelated upstream test module.This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
PipeStopStrategyPipeRecentFailureCounterPipeAbstractSinkSubtaskIoTDBDataRegionAsyncSinkPipeTemporaryMetaInAgent/PipeTemporaryMetaInCoordinatorSHOW PIPESresponse paths