Fix repeated WAL scans during subscription catch-up - #18392
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reuse the WAL iterator during historical catch-up
A bounded consensus-subscription prefetch round recreated
ProgressWALIteratoratnextExpectedSearchIndexbefore reading each batch. The iterator still opens retained WAL files from the beginning and appliesstartSearchIndexonly after request deserialization, so every batch repeatedly scanned all earlier WAL entries. The resulting read amplification grew with catch-up progress and made consumption progressively slower.This change keeps the existing iterator, including its WAL reader cursor and buffered look-ahead request, across normal bounded prefetch rounds. Explicit resets remain in place for seek, WAL-gap recovery, exhausted live WAL refresh, and memory rollback.
Regression coverage
A real sealed-WAL test limits each batch to one entry and verifies that three consecutive catch-up rounds:
ProgressWALIterator;Verification
Tests run: 29, Failures: 0, Errors: 0, Skipped: 0.
This PR has:
Key changed/added classes
ConsensusPrefetchingQueueConsensusPrefetchingQueueWalBackpressureTest