KNOX-3287: RAP truststore password alias improvements#1190
Merged
moresandeep merged 2 commits intoapache:masterfrom Mar 31, 2026
Merged
KNOX-3287: RAP truststore password alias improvements#1190moresandeep merged 2 commits intoapache:masterfrom
moresandeep merged 2 commits intoapache:masterfrom
Conversation
Test Results7 tests 7 ✅ 1s ⏱️ Results for commit 0105575. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces improvements to how the Remote Authentication Provider (RAP) handles truststore password aliases, along with a fix for recent build failures.
Key Changes:
RemoteAuthFilter: Replaced the hardcoded truststore.password configuration with a new truststore.password.alias configuration to better support alias-based password resolution.
Alias Resolution: Improved getTruststorePassword to cleanly resolve the truststore password alias first at the cluster level, and falling back to the gateway level (AliasService.NO_CLUSTER_NAME) if it's not found.
Docker Entrypoint: Added support for the RAP_TRUSTSTORE_PASSWORD environment variable in gateway-entrypoint.sh to automatically save the remote auth provider truststore password alias on container startup.
Tests:
Updated RemoteAuthFilterTest to reflect the new truststore.password.alias configuration key.