KNOX-3291 - Fix modern theme 'Sign In' button style#1192
Merged
hanicz merged 3 commits intoapache:masterfrom Mar 31, 2026
Merged
KNOX-3291 - Fix modern theme 'Sign In' button style#1192hanicz merged 3 commits intoapache:masterfrom
hanicz merged 3 commits intoapache:masterfrom
Conversation
Test Results7 tests 7 ✅ 1s ⏱️ Results for commit 96f4107. ♻️ This comment has been updated with latest results. |
moresandeep
approved these changes
Mar 30, 2026
Contributor
moresandeep
left a comment
moresandeep
left a comment
There was a problem hiding this comment.
Looks good, there is a green line in the first image, i am assuming that is not how it actually renders but a issue with screenshot.
Contributor
Author
Thats the 'before' image. It had that bug when the button was hovered. |
moresandeep
pushed a commit
to moresandeep/knox
that referenced
this pull request
Mar 31, 2026
* KNOX-3291: Fixed modern theme 'Sign In' button style * KNOX-3291: Fix green 'Flash' when on SIgn In button when enter is used * KNOX-3291: Changed background color to grey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3291 - Fix modern theme 'Sign In' button style
What changes were proposed in this pull request?
How was this patch tested?
Tested locally on up-to-date Chrome and Firefox
Integration Tests
N/A
UI changes
Old button while hovered:
New button while hovered and background:
No hover
Spinner
