Remove Profile getSource / setSource

[gnodet]

Summary

• Removes Profile.getSource(), Profile.setSource(), Profile.SOURCE_POM, and Profile.SOURCE_SETTINGS starting at model version 4.2.0 (per Remove profile getSource / setSource #2569)
• The 4.0.0 and 4.1.0 model versions retain these methods for backward compatibility (the 4.0.0 segment now uses its own field instead of delegating to the API model)
• Replaces usages in the impl layer with InputLocation / InputSource checks: POM profiles are identified by having a non-null InputSource.getModelId()
• The compat layer is unchanged — it still has getSource()/setSource() via its own model code segment

Files changed (3):

• api/maven-api-model/src/main/mdo/maven.mdo — split 4.1.0+ segment into 4.1.0/4.1.99 (keeps source methods) and 4.2.0+ (removes them); fix 4.0.0/4.0.99 to use own field instead of delegating
• impl/maven-impl/.../DefaultProfileSelector.java — replace Profile.SOURCE_POM.equals(profile.getSource()) with isFromPom() using InputSource.getModelId()
• impl/maven-impl/.../SettingsUtilsV4.java — remove value.setSource("settings.xml")

Closes #2569

Test plan

• Full build passes (all 38 modules, all tests green)
• API Profile (4.2.0+) no longer has getSource/setSource
• Compat Profile retains getSource/setSource via own field
• No japicmp compatibility violations
• CI build passes

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Removes legacy Profile source tracking (getSource/setSource and related constants) from the API model starting with model version 4.2.0, and updates the impl layer to distinguish POM vs settings profiles via InputLocation/InputSource (per #2569).

Changes:

• Split API model code generation segments so Profile.getSource/setSource exist only for 4.0.x and 4.1.x, and are removed for 4.2.0+.
• Update DefaultProfileSelector to classify “from POM” profiles based on a non-empty InputSource.getModelId().
• Remove impl-layer writes to Profile.setSource("settings.xml") and add tests covering the updated activation behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultProfileSelectorTest.java	Adds coverage for POM vs settings profile handling using InputSource model id, including edge cases.
impl/maven-impl/src/main/java/org/apache/maven/impl/SettingsUtilsV4.java	Stops setting Profile source explicitly; relies on InputLocation/InputSource instead.
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultProfileSelector.java	Replaces Profile.getSource() checks with InputSource.getModelId()-based origin detection.
api/maven-api-model/src/main/mdo/maven.mdo	Adjusts generated API model versions: retains source API for 4.0.x/4.1.x and removes it for 4.2.0+.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gnodet]

LGTM — Clean removal of the legacy Profile.getSource()/setSource() methods from the 4.2.0+ API model, correctly replacing usages in the impl layer with InputSource.getModelId() checks. The compat layer retains backward compatibility for 4.0.x/4.1.x consumers.

Highlights:

• The version segmentation strategy (4.0.0/4.0.99, 4.1.0/4.1.99, 4.2.0+) is well-structured and ensures backward compatibility at each layer
• The replacement mechanism using InputSource.getModelId() is sound: POM profiles get a modelId during parsing while settings profiles get an empty string, naturally distinguishing profile sources without a separate mutable field
• The new DefaultProfileSelectorTest is thorough: covers POM-only, settings-only, mixed, null-modelId, no-location, and exception cases
• japicmp passes, confirming no binary compatibility violations
• CI is fully green across all platforms

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet