Expanding list of recognized JavaScript and TypeScript extensions#9427
Open
jtulach wants to merge 1 commit into
Open
Expanding list of recognized JavaScript and TypeScript extensions#9427jtulach wants to merge 1 commit into
jtulach wants to merge 1 commit into
Conversation
jtulach
added
JavaScript
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
The additions in general make sense to me. The extension squatting is worrisome, but that is is different discussion.
Two extension jumped my eye:
es6: I assume this shall say, that this is ECMA Script 6 code. Is this really commonly used?pac: I assume these are proxy autoconfiguration scripts. Are these normally named like this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with modern JavaScript I noticed increased presence of files with
.mjsand.cjsextensions. The leadingmsignals to the JavaScript engine that the file is supposed to be treated as ECMAScript module. The leadingcsignals CommonJS module. The same pattern seems to emerge in TypeScript as well. Let NetBeans extensions for JavaScript and TypeScript be expanded to cover these widely used extensions!.mjsis needed: https://github.com/oracle/graaljs/blob/33e69fbb659cc796867cf17f0adcc89d05bfe0e9/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/lang/JavaScriptLanguage.java#L168Previously I always expanded the list of extensions manually in Tools/Options, but given how frequent they have become I believe enlisting them by default would improve the UX.