nsh/echo: Fix echo command to keep original behavior adding a '\n' as a single write()#3565
Open
acassis wants to merge 1 commit into
Open
nsh/echo: Fix echo command to keep original behavior adding a '\n' as a single write()#3565acassis wants to merge 1 commit into
acassis wants to merge 1 commit into
Conversation
acassis
requested review from
cederom,
jerpelea,
linguini1,
simbit18 and
xiaoxiang781216
acassis
force-pushed
the
fix_nsh_echo
branch
2 times, most recently
from
2fe8bd2 to
59413a7
Compare
This commit fixes the previous behavior where an echo with a single string and its default new line is send as single write(). This issue came from: apache#1559 Signed-off-by: Alan C. Assis <acassis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes the previous behavior where an echo with a single string and its default new line is send as single write().
This issue came from: #1559
Impact
Keep original behavior of echo command
Testing
nsh> echo Hello
Hello
nsh> echo "Hello World"
Hello World
nsh> echo "Hello" "World"
Hello World
nsh> echo "t120o1l16b9n0baan0bn0bn0baaan0b9n0baan0b" > /dev/tone0
Received 41 byte(s)
nsh>