feat(services/obs): support if_modified_since and if_unmodified_since…#7708
Merged
Conversation
dosubot
Bot
added
size:S
… on read (part of apache#5486)
YuangGao
force-pushed
the
feat/obs-conditional-read
branch
from
23d30ff to
8a1023e
Compare
erickguan
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5486.
Rationale for this change
OBS read already wires
if_match/if_none_matchbut ignores the date-based conditionals. OBS is S3-compatible and honorsIf-Modified-Since/If-Unmodified-Sinceon GET per RFC 7232. Other backends (s3, azblob, oss, cos, tos, swift, http, webdav, azdls) already wire them.What changes are included in this PR?
If-Modified-Since/If-Unmodified-Sinceinobs_get_object_request.read_with_if_modified_since,read_with_if_unmodified_sinceon the obs service capability.Are there any user-facing changes?
op.reader_with(...)conditionals now work on obs backends. No breaking changes; existing capability-gated behavior tests auto-cover the new flags.AI Usage Statement
AI-assisted implementation.