Skip to content

OPENNLP-1899: Harden SymSpell model deserialization against oversized count fields - #1197

Merged
rzo1 merged 1 commit into
mainfrom
OPENNLP-1899
Jul 28, 2026
Merged

OPENNLP-1899: Harden SymSpell model deserialization against oversized count fields#1197
rzo1 merged 1 commit into
mainfrom
OPENNLP-1899

Conversation

@rzo1

@rzo1 rzo1 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@rzo1
rzo1 requested review from atarora, jzonthemtn and krickert July 28, 2026 17:04
@rzo1 rzo1 self-assigned this Jul 28, 2026
@rzo1
rzo1 marked this pull request as ready for review July 28, 2026 17:04

@krickert krickert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward, tests written well, well covered. LGTM

@rzo1
rzo1 merged commit 014c018 into main Jul 28, 2026
9 of 10 checks passed
@rzo1
rzo1 deleted the OPENNLP-1899 branch July 28, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants